HomeFreeBSD

sysctl: hide 2.x era compat node
AuditedrS356262

Description

sysctl: hide 2.x era compat node

r23081 introduced kern.dummy oid as a semi ABI compat for kern.maxsockbuf
that was moved to a new namespace. It never functioned as an alias of any
kind and was just returning 0 unconditionally, hence it was probably
provided to keep some 3rd party programmes happy about sysctl(3) not
reporting an error because of non-existing oid.
After nearly 23 years it seems reasonable to just hide it from sysctl(8)
list not to cause unnecessary confusion as for its purpose.

Reported by: Antranig Vartanian <antranigv@freebsd.am>
Reviewed by: kib (mentor)
Approved by: kib (mentor)
Differential Revision: https://reviews.freebsd.org/D22982

Details

Auditors
wollman
Committed
kaktusJan 2 2020, 1:23 AM
Reviewer
kib
Differential Revision
D22982: sysctl: hide 2.x era compat node
Parents
rS356261: vfs: drop an always-false check from vlrureclaim
Branches
Unknown
Tags
Unknown

Event Timeline

wollman accepted this commit.Jan 3 2020, 3:03 AM
wollman added a subscriber: wollman.

I wrote this, a very long time ago in a career far away. I suspect it can be deleted entirely, but this is a reasonable thing to do right now. Nobody should still be using any code that depended on the old kern.maxsockbuf sysctl node number.

All concerns with this commit have now been addressed.Jan 3 2020, 3:04 AM