HomeFreeBSD

iommu static analysis cleanup

Description

iommu static analysis cleanup

A static analyzer complained about a couple instances of checking a
variable against NULL after already having dereferenced it.

  • dmar_gas_alloc_region: remove the tautological NULL checks
  • dmar_release_resources / dmar_fini_fault_log: don't deref unit->regs unless initialized.

And while here, fix an inverted initialization check in dmar_fini_qi.

Reviewed by: kib
Sponsored by: Dell EMC Isilon
Differential revision: https://reviews.freebsd.org/D20263

Details

Provenance
rlibbyAuthored on
Reviewer
kib
Differential Revision
D20263: iommu static analysis cleanup
Parents
rS347644: MFC r347032 (except for the part about d_off):
Branches
Unknown
Tags
Unknown