HomeFreeBSD

MFC r343395:

Description

MFC r343395:
Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6
connectivity.

Looking at past changes in this area like r337866, some refcounting
bugs have been introduced, one by one. For example like calling
in6m_disconnect() and in6m_rele_locked() in mld_v1_process_group_timer()
where previously no disconnect nor refcount decrement was done.
Calling in6m_disconnect() when it shouldn't causes IPv6 solitation to no
longer work, because all the multicast addresses receiving the solitation
messages are now deleted from the network interface.

This patch reverts some recent changes while improving the MLD
refcounting and concurrency model after the MLD code was converted
to using EPOCH(9).

List changes:

  • All CK_STAILQ_FOREACH() macros are now properly enclosed into EPOCH(9) sections. This simplifies assertion of locking inside in6m_ifmultiaddr_get_inm().
  • Corrected bad use of in6m_disconnect() leading to loss of IPv6 connectivity for MLD v1.
  • Factored out checks for valid inm structure into in6m_ifmultiaddr_get_inm().

PR: 233535
Differential Revision: https://reviews.freebsd.org/D18887
Reviewed by: bz (net)
Tested by: ae
Sponsored by: Mellanox Technologies

Details

Provenance
hselaskyAuthored on
Reviewer
bz
Differential Revision
D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity
Parents
rS343649: MFC r343394:
Branches
Unknown
Tags
Unknown