HomeFreeBSD

Fix an LLE lookup race.

Description

Fix an LLE lookup race.

After the afdata read lock was converted to epoch(9), readers could
observe a linked LLE and block on the LLE while a thread was
unlinking the LLE. The writer would then release the lock and schedule
the LLE for deferred free, allowing readers to continue and potentially
schedule the LLE timer. By the point the timer fires, the structure is
freed, typically resulting in a crash in the callout subsystem.

Fix the problem by modifying the lookup path to check for the LLE_LINKED
flag upon acquiring the LLE lock. If it's not set, the lookup fails.

PR: 234296
Reviewed by: bz
Tested by: sbruno, Victor <chernov_victor@list.ru>,

		Mike Andrews <mandrews@bit0.com>

MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D18906

Details

Provenance
markjAuthored on
Reviewer
bz
Differential Revision
D18906: Fix an LLE lookup race.
Parents
rS343362: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile
Branches
Unknown
Tags
Unknown