HomeFreeBSD

MFC 338976: Don't clear DR6 for debug exceptions from userland.

Description

MFC 338976: Don't clear DR6 for debug exceptions from userland.

This reverts part of r333368. The attempt to clear DR6 was occuring
too soon as trapsignal() does not pause to let the debugger notice the
SIGTRAP and query DR6. The signal exchange does not occur until much
later during ast(). As a result, GDB was no longer recognizing
hardware breakpoints and watchpoints on x86.

In addition, any userland programs that want to inspect DR6 in a
SIGTRAP handler don't have a way to do this if we clear DR6 in the
exception handler.

Instead of relying on the kernel to clear DR6, debuggers will have to
explicitly clear it after a trace trap (which they needed to do on
older kernels anyway).

Details

Provenance
jhbAuthored on
Parents
rS339272: Don't include the broken riscv64sf TARGET_ARCH in universe.
Branches
Unknown
Tags
Unknown