top(1): top warnings and cleanup

• Add const where helpful
• add missing 'static' for file-local functions
• use nitems where possible
• convert manual abort() to assert
• use strndup instead of homegrown version

Tested with clang, gcc7, and gcc9