HomeFreeBSD

pf: Improve ioctl validation for DIOCRADDTABLES and DIOCRDELTABLES

Description

pf: Improve ioctl validation for DIOCRADDTABLES and DIOCRDELTABLES

The DIOCRADDTABLES and DIOCRDELTABLES ioctls can process a number of
tables at a time, and as such try to allocate <number of tables> *
sizeof(struct pfr_table). This multiplication can overflow. Thanks to
mallocarray() this is not exploitable, but an overflow does panic the
system.

Arbitrarily limit this to 65535 tables. pfctl only ever processes one
table at a time, so it presents no issues there.

MFC after: 1 week

Details

Provenance
kpAuthored on
Parents
rS332100: Let syslog(3) use RFC 5424.
Branches
Unknown
Tags
Unknown