HomeFreeBSD

MFC r326640:

Description

MFC r326640:

Optimize telldir(3)

Currently each call to telldir() requires a malloc and adds an entry to a
linked list which must be traversed on future telldir(), seekdir(),
closedir(), and readdir() calls. Applications that call telldir() for every
directory entry incur O(n^2) behavior in readdir() and O(n) in telldir() and
closedir().

This optimization eliminates the malloc() and linked list in most cases by
packing the relevant information into a single long. On 64-bit architectures
msdosfs, NFS, tmpfs, UFS, and ZFS can all use the packed representation. On
32-bit architectures msdosfs, NFS, and UFS can use the packed
representation, but ZFS and tmpfs can only use it for about the first 128
files per directory. Memory savings is about 50 bytes per telldir(3) call.
Speedup for telldir()-heavy directory traversals is about 20-30x for one
million files per directory.

Reviewed by: kib, mav, mckusick
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D13385

Details

Provenance
asomersAuthored on
Reviewer
kib
Differential Revision
D13385: Optimize telldir(3)
Parents
rS327849: MFC r326624:
Branches
Unknown
Tags
Unknown