HomeFreeBSD

iscsi: do not hold the global lock while tearing down a session

Description

iscsi: do not hold the global lock while tearing down a session

It should be sufficient to hold the lock just for removing the session
from the session list. Everything else should be covered by the session
specific lock.

On top of that, at present we can get a deadlock caused by waiting on
the CAM SIM reference count while holding the global lock. A specific
scenario involving ZFS is this:

  • concurrent termination of two sessions, S1 and S2
  • session S1 completed all I/Os and sleeps in CAM waiting for device close by ZFS;
  • session S2 is also dead now, but can not forcefully complete outstanding requests by calling iscsi_session_cleanup() from iscsi_maintenance_thread_terminate(), since it can't get the same global sc_lock;
  • as soon as there are unfinished requests, ZFS can not do spa_config_enter() as writer, and so can not close the device for session S1;
  • deadlock.

Reported by: Ben RUBSON <ben.rubson@gmail.com>
Tested by: Ben RUBSON <ben.rubson@gmail.com>
Reviewed by: mav, trasz
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D12652

Details

Provenance
avgAuthored on
Reviewer
mav
Differential Revision
D12652: iscsi: do not hold the global lock while tearing down a session
Parents
rS324688: DragonFly 5.0.0 release added.
Branches
Unknown
Tags
Unknown