HomeFreeBSD

libthr: Use CLI flags instead of pragmas to disable warnings

Description

libthr: Use CLI flags instead of pragmas to disable warnings

People tweaking the build system or compilers tend to look into
the Makefile and not into the source. Having some warning controls
in the Makefile and some in the source code is surprising.

Pragmas have the advantage that they leave the warnings enabled
for more code, but that advantage isn't very relevant in these cases.

Requested by: kib
Reviewed by: kib
MFC after: 3 days
Sponsored by: Dell EMC
Differential Revision: https://reviews.freebsd.org/D10832

Details

Provenance
vangyzenAuthored on
Reviewer
kib
Differential Revision
D10832: libthr: use default WARNS level of 6, and fix warnings
Parents
rS318583: libthr: use default WARNS level of 6
Branches
Unknown
Tags
Unknown