HomeFreeBSD

gpt*boot: Save a bit more memory when LOADER_NO_GELI_SUPPORT is specified
Concern RaisedrS316078

Description

gpt*boot: Save a bit more memory when LOADER_NO_GELI_SUPPORT is specified

Don't compile geliargs into the image and don't pass geliargs to the respective
bootloader code via __exec(..).

This saves a negligible amount of memory/disk space.

X-MFC with: r296963
Obtained from: Isilon OneFS
Sponsored by: Dell EMC Isilon

Details

Auditors
allanjude
Provenance
ngieAuthored on
Parents
rS316077: Unbreak compilation with gcc 4.2.1
Branches
Unknown
Tags
Unknown

Event Timeline

allanjude added a subscriber: allanjude.
allanjude added inline comments.
/head/sys/boot/i386/gptboot/gptboot.c
488

In the case where we are not passing geliargs, we should pass 0 instead of KARGS_FLAGS_EXTARG, else the loader will look for an additional parameter. This is how it was before rS296963

Do you agree?

This commit now has outstanding concerns.Apr 1 2017, 5:11 AM
ngie marked an inline comment as done.Apr 1 2017, 7:00 PM
ngie added inline comments.
/head/sys/boot/i386/gptboot/gptboot.c
488

Agreed

ngie marked an inline comment as done.Apr 1 2017, 7:11 PM