HomeFreeBSD

Use PC-relative relocations for USDT probe sites on i386 and amd64.

Description

Use PC-relative relocations for USDT probe sites on i386 and amd64.

When recording probe site addresses in the output DOF file, dtrace -G
needs to emit relocations for the .SUNW_dof section in order to obtain
the addresses of functions containing probe sites. DTrace expects the
addresses to be relative to the base address of the final ELF file,
and the amd64 USDT implementation was relying on some unspecified and
incorrect behaviour in the base system GNU ld to achieve this.

This change reimplements the probe site relocation handling to allow
USDT to be used with lld and newer GNU binutils. Specifically, it
makes use of R_X86_64_PC64/R_386_PC32 relocations to obtain the
probe site address relative to the DOF file address, and adds and uses a
new DOF relocation type which computes the final probe site address using
these relative offsets.

Reported by and discussed with: Rafael EspĂ­ndola
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D9374

Details

Provenance
markjAuthored on
Differential Revision
D9374: Use PC-relative relocations for USDT probe offsets on x86
Parents
rS313261: Make witness_warn() always print to the console.
Branches
Unknown
Tags
Unknown