HomeFreeBSD

bridge: Release the bridge lock when calling bridge_set_ifcap()

Description

bridge: Release the bridge lock when calling bridge_set_ifcap()

This calls ioctl() handlers for the different interfaces in the bridge.
These handlers expect to get called in an ioctl context where it's safe
for them to sleep. We may not sleep with the bridge lock held.

However, we still need to protect the interface list, to ensure it
doesn't get changed while we iterate over it.
Use BRIDGE_XLOCK(), which prevents bridge members from being removed.
Adding bridge members is safe, because it uses LIST_INSERT_HEAD().

This caused panics when adding xen interfaces to a bridge.

PR: 216304
Reviewed by: ae
MFC after: 1 week
Sponsored by: RootBSD
Differential Revision: https://reviews.freebsd.org/D9290

Details

Provenance
kpAuthored on
Reviewer
ae
Differential Revision
D9290: bridge: Release the bridge lock when calling bridge_set_ifcap()
Parents
rS312781: Also apply WITH_LLD_AS_LD to build tools
Branches
Unknown
Tags
Unknown