Diffusion FreeBSD src repository - subversion rS310850

dosfs support in libstand is broken since r298230
rS310850
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

dosfs support in libstand is broken since r298230

Apparently the libstand dosfs optimization is a bit too optimistic
and did introduce possible memory corruption.

This patch is backing out the bad part and since this results in
dosfs reading full blocks now, we can also remove extra offset argument
from dv_strategy callback.

The analysis of the issue and the backout patch is provided by Mikhail Kupchik.

PR: 214423
Submitted by: Mikhail Kupchik
Reported by: Mikhail Kupchik
Reviewed by: bapt, allanjude
Approved by: allanjude (mentor)
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D8644

Details

Provenance

Authored on

Reviewer

Differential Revision

D8644: loader: dosfs can corrupt memory

Parents

rS310849: Fix two similar bugs in the populate vm_fault() code.

Branches

Unknown

Tags

Unknown

Event Timeline

tsoome committed rS310850: dosfs support in libstand is broken since r298230.Dec 30 2016, 7:06 PM

Changes (30)

Path

Size

head/

lib/

libstand/

sys/

boot/

common/

efi/

libefi/

i386/

libfirewire/

libi386/

mips/

beri/

loader/

beri_disk_cfi.c

beri_disk_sdcard.c

ofw/

libofw/

pc98/

libpc98/

powerpc/

kboot/

ps3/

uboot/

lib/

usb/

storage/

userboot/

userboot/

userboot_disk.c

zfs/

rS310850

head/lib/libstand/cd9660.c

Loading...

head/lib/libstand/dosfs.c

Loading...

head/lib/libstand/ext2fs.c

Loading...

head/lib/libstand/nandfs.c

Loading...

head/lib/libstand/read.c

Loading...

head/lib/libstand/stand.h

Loading...

head/lib/libstand/ufs.c

Loading...

head/lib/libstand/write.c

Loading...

head/sys/boot/common/bcache.c

Loading...

head/sys/boot/common/bootstrap.h

Loading...

head/sys/boot/common/disk.c

Loading...

head/sys/boot/common/md.c

Loading...

head/sys/boot/efi/libefi/efipart.c

Loading...

head/sys/boot/i386/libfirewire/firewire.c

Loading...

head/sys/boot/i386/libi386/bioscd.c

Loading...

head/sys/boot/i386/libi386/biosdisk.c

Loading...

head/sys/boot/i386/libi386/pxe.c

Loading...

head/sys/boot/mips/beri/loader/beri_disk_cfi.c

Loading...

head/sys/boot/mips/beri/loader/beri_disk_sdcard.c

Loading...

head/sys/boot/ofw/libofw/ofw_disk.c

Loading...

head/sys/boot/pc98/libpc98/bioscd.c

Loading...

head/sys/boot/pc98/libpc98/biosdisk.c

Loading...

head/sys/boot/powerpc/kboot/hostdisk.c

Loading...

head/sys/boot/powerpc/ps3/ps3cdrom.c

Loading...

head/sys/boot/powerpc/ps3/ps3disk.c

Loading...

head/sys/boot/uboot/lib/disk.c

Loading...

head/sys/boot/usb/storage/umass_loader.c

Loading...

head/sys/boot/userboot/userboot/host.c

Loading...

head/sys/boot/userboot/userboot/userboot_disk.c

Loading...

head/sys/boot/zfs/zfs.c

Loading...