HomeFreeBSD
Diffusion FreeBSD src repository - subversion rS301185

Address feedback from hrs@ re: r301059 (ifconfig subnet mask)
rS301185
Actions

Description

Address feedback from hrs@ re: r301059 (ifconfig subnet mask)

  • Use NI_MAXHOST to size buffers for getnameinfo()
  • remove non-standard 'full' inet6 address printing
  • remove 'no scope' option
  • use strchr(3) to optimize replacing separator character in lladdrs

Reviewed by: gnn, jhb
Differential Revision: https://reviews.freebsd.org/D2856

Details

Provenance
allanjudeAuthored on
Reviewer
gnn
Differential Revision
D2856: make ifconfig print ipv4 netmasks in dotted-quad notation, rather than hex
Parents
rS301184: MFC r300758:
Branches
Unknown
Tags
Unknown

Event Timeline

allanjude committed rS301185: Address feedback from hrs@ re: r301059 (ifconfig subnet mask).Jun 2 2016, 3:16 AM
aly_aaronly.me added a subscriber: aly_aaronly.me.Jun 26 2020, 5:13 AM

Minor cleanup suggestion.

/head/sbin/ifconfig/af_link.c
72

This actually should be format_char = strchr(format_char, ':'), although the final result is correct.
In addition, a while loop likes while ((format_char = strchr(format_char, ':') != NULL) would be more concise.

allanjude mentioned this in rS362654: ifconfig(8): optimize -f ether:dash mode.Jun 26 2020, 4:20 PM

Changes (5)

PathSize
head/
sbin/
ifconfig/

rS301185

View Options

head/sbin/ifconfig/af_inet.c

Loading...
View Options

head/sbin/ifconfig/af_inet6.c

Loading...
View Options

head/sbin/ifconfig/af_link.c

Loading...
View Options

head/sbin/ifconfig/ifconfig.8

Loading...
View Options

head/sbin/ifconfig/ifconfig.c

Loading...