HomeFreeBSD

Large improvements to efi-show (though some weird problems

Description

Large improvements to efi-show (though some weird problems
linger). We now print only printable characters for the
values and we print ascii strings as strings.

Details

Provenance
impAuthored on
Parents
rS300329: Implement efi-set and efi-unset
Branches
Unknown
Tags
Unknown

Event Timeline

tsoome added inline comments.
/head/sys/boot/efi/loader/main.c
717

you should check the uuid_status after this call.

719

this branch will leak str from uuid_to_string(). Suggest to move the printf out of if statement and free(str).

/head/sys/boot/efi/loader/main.c
737

This loop is broken on vmware fusion. Either dump by bytes or just print message like:

xx bytes of data.

777

need to add:

optind = 1;
optreset = 1;

or second call to getopt() will be broken.