HomeFreeBSD

Have lockstat(1) trace locks by name rather than by address.

Description

Have lockstat(1) trace locks by name rather than by address.

Previously, lockstat(1) would use a lock's address as its identifier when
consuming data describing lock contention and hold events. After collecting
the requested data, it would use ksyms(4) to resolve lock addresses to
names. Of course, this doesn't work too well for locks contained in
dynamically-allocated memory. This change modifies lockstat(1) to trace the
lock names obtained from the base struct lock_object instead, leading to
output that is generally much more useful.

This change also removes the -c option, which is used to coalesce data for
locks in an array. It's not possible to support this option without also
tracing lock addresses, and since lock arrays in which the lock names are
distinct are not very common in FreeBSD, it's simpler to just remove the
option.

Reviewed by: avg (earlier revision)
Differential Revision: https://reviews.freebsd.org/D3661

Details

Provenance
markjAuthored on
Reviewer
avg
Differential Revision
D3661: lockstat(1): use lock names instead of addresses
Parents
rS288416: Update DTrace test makefiles after r288415.
Branches
Unknown
Tags
Unknown