HomeFreeBSD

Don't acquire sysctlmemlock in userland_sysctl() when the old value

Description

Don't acquire sysctlmemlock in userland_sysctl() when the old value
pointer is NULL, as in that case there are no userland pages that
could potentially be wired. It is common for old to be NULL and
oldlenp to be non-NULL in calls to userland_sysctl(), as this is used
to probe for the length of a variable-length sysctl entry before
retrieving a value. Note that it is typical for such calls to be made
with an uninitialized value in *oldlenp, so sysctlmemlock was
essentially being acquired at random (depending on the uninitialized
value in *oldlenp being > PAGE_SIZE or not) for these calls prior to
this patch.

Differential Revision: https://reviews.freebsd.org/D2987
Reviewed by: mjg, kib
Approved by: jmallett (mentor)
MFC after: 1 month

Details

Provenance
pkelseyAuthored on
Reviewer
mjg
Differential Revision
D2987: Don't acquire sysctlmemlock unnecessarily
Parents
rS285207: Mutex memory is not zeroed, add MTX_NEW.
Branches
Unknown
Tags
Unknown