Diffusion FreeBSD src repository fd9e09cb2ab0

kern: replace several EBADF with EINVAL
fd9e09cb2ab0
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

kern: replace several EBADF with EINVAL

EBADF semantic is that the passed fd is invalid, not that it is of wrong
type. Using EBADF in these places in kern_event.c and sys_procdesc.c
give bad examples to copy from.

Note that places in kern_event.c that checks KQ_CLOSING and return EBADF
are kept, since KQ_CLOSING is the transient state before the fd is
finally closed and become eligible for EBADF.

Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D52410

Details

Provenance

kib	Authored on Sep 7 2025, 10:59 AM

Reviewer

Differential Revision

D52410: kern: replace several EBADF with EINVAL

Parents

rGfdb3b695a4d1: Update the installed manpages to match OpenSSL 3.5.1

Branches

Unknown

Tags

Unknown

Reverted By

rGa85525a5c8b2: pdgetpid(2): switch back returning EBADF for non-procdesc fd

Event Timeline

kib committed rGfd9e09cb2ab0: kern: replace several EBADF with EINVAL (authored by kib).Sep 8 2025, 3:01 AM

kib added an edge: D52410: kern: replace several EBADF with EINVAL.Sep 8 2025, 3:04 AM

jamie mentioned this in rG16f600dc30b7: jaildesc: replace EBADF with EINVAL.Sep 9 2025, 6:18 PM

jamie mentioned this in rG595a705062de: MFC jaildesc: replace EBADF with EINVAL.Sep 13 2025, 11:45 PM

kib added a reverting change: rGa85525a5c8b2: pdgetpid(2): switch back returning EBADF for non-procdesc fd.Sep 14 2025, 8:14 AM

kib mentioned this in rGac3444a9528e: kern: replace several EBADF with EINVAL.Sat, Oct 11, 5:08 AM

kib mentioned this in rG3bd1780213bf: kern: replace several EBADF with EINVAL.Mon, Oct 13, 12:30 AM

Changes (2)

Path

Size

sys/

kern/

rGfd9e09cb2ab0

sys/kern/kern_event.c

Loading...

sys/kern/sys_procdesc.c

Loading...