HomeFreeBSD

Set spa_ccw_fail_time=0 when expanding a vdev.

Description

Set spa_ccw_fail_time=0 when expanding a vdev.

When a vdev is to be expanded -- either via zpool online -e or via
the autoexpand option -- a SPA_ASYNC_CONFIG_UPDATE request is queued
to be handled via an asynchronous worker thread (spa_async_thread).
This normally happens almost immediately; but will be delayed up to
zfs_ccw_retry_interval seconds (default 5 minutes) if an attempt to
write the zpool configuration cache failed.

When FreeBSD boots ZFS-root VM images generated using makefs -t zfs,
the zpoolupgrade rc.d script runs zpool upgrade, which modifies the
pool configuration and triggers an attempt to write to the cache file.
This attempted write fails because the filesystem is still mounted
read-only at this point in the boot process, triggering a 5-minute
cooldown before SPA_ASYNC_CONFIG_UPDATE requests will be handled by
the asynchronous worker thread.

When expanding a vdev, reset the "when did a configuration cache
write last fail" value so that the SPA_ASYNC_CONFIG_UPDATE request
will be handled promptly. A cleaner but more intrusive option would
be to use separate SPA_ASYNC_ flags for "configuration changed" and
"try writing the configuration cache again", but with FreeBSD 14.0
coming very soon I'd prefer to leave such refactoring for a later
date.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Colin Percival <cperciva@FreeBSD.org>
Closes #15405

Details

Provenance
cpercivaAuthored on Oct 20 2023, 5:30 PM
GitHub <noreply@github.com>Committed on Oct 20 2023, 5:30 PM
Parents
rGf0f330e1212e: Fix ZED auto-replace for VDEVs using by-id paths
Branches
Unknown
Tags
Unknown