HomeFreeBSD

riscv: Fix a race in pmap_pinit()

Description

riscv: Fix a race in pmap_pinit()

All pmaps share the top half of the address space. With 3-level page
tables, the top-level kernel map entries are not static: they might
change if the kernel map is extended (via pmap_growkernel()) or a 1GB
mapping in the direct map is demoted (not implemented yet). Thus the
riscv pmap maintains the allpmaps list to synchronize updates to
top-level entries.

When a pmap is created, it is inserted into this list after copying
top-level entries from the kernel pmap. The copying is done without
holding the allpmaps lock, and it is possible for pmap_pinit() to race
with kernel map updates. In particular, if a thread is modifying L1
entries, and a concurrent pmap_pinit() copies the old version of the
entries, it might not receive the update.

Fix the problem by copying the kernel map entries after inserting the
pmap into the list. This ensures that the nascent pmap always receives
updates, though pmap_distribute_l1() may race with the page copy.

Reviewed by: mhorne, jhb
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D34158

Details

Provenance
markjAuthored on Feb 8 2022, 6:15 PM
Reviewer
mhorne
Differential Revision
D34158: riscv: Fix a race in pmap_pinit()
Parents
rG5de79eeddb9d: ktls: Disallow transmitting empty frames outside of TLS 1.0/CBC mode
Branches
Unknown
Tags
Unknown