HomeFreeBSD

ping: fix parsing of options including '4' and '6'

Description

ping: fix parsing of options including '4' and '6'

ping uses a two-pass option parser. The first pass determines whether
ipv4 or ipv6 is desired, and the second parses the rest of the options.
But the first pass wrongly detects a '4' or '6' in an option's value as
a request to use ipv6 or ipv6 respectively, for example in an invocation
like "ping -c6 1.2.3.4".

Fix this confusion by including all options in the first round of
parsing, but ignoring those unrelated to ipv4/ipv6 selection.

PR: 258048
Reported by: ghuckriede@blackberry.com
Submitted by: ghuckriede@blackberry.com
MFC after: 2 weeks
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D32344

(cherry picked from commit 9ce201f2ee3ca340032d9cc71d91a36b3b45a4c3)

Details

Provenance
asomersAuthored on Oct 6 2021, 10:54 PM
emasteCommitted on Dec 13 2021, 1:27 AM
Reviewer
emaste
Differential Revision
D32344: ping: fix parsing of options including '4' and '6'
Parents
rG4bad5bb129b8: inetd: Use the synopsis from the manual page
Branches
Unknown
Tags
Unknown