HomeFreeBSD

mpr/mps/mpt: verify cfg page ioctl lengths

Description

mpr/mps/mpt: verify cfg page ioctl lengths

*_CFG_PAGE ioctl handlers in the mpr, mps, and mpt drivers allocated a
buffer of a caller-specified size, but copied to it a fixed size header.
Add checks that the size is at least the required minimum.

Note that the device nodes are owned by root:operator with 0640
permissions so the ioctls are not available to unprivileged users.

This change includes suggestions from scottl, markj and mav.

Two of the mpt cases were reported by Lucas Leong (@_wmliang_) of
Trend Micro Zero Day Initiative; scottl reported the third case in mpt.
Same issue found in mpr and mps after discussion with imp.

Reported by: Lucas Leong (@_wmliang_), Trend Micro Zero Day Initiative
Reviewed by: imp, mav
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D34692

(cherry picked from commit 8276c4149b5fc7c755d6b244fbbf6dae1939f087)
(cherry picked from commit 56d0638c738e3f9b7fbc7f78bd49590523e01ada)

Approved by: so
Security: CVE-2022-23086
Security: FreeBSD-SA-22:06.ioctl

Details

Provenance
emasteAuthored on Apr 5 2022, 11:21 PM
Reviewer
imp
Differential Revision
Restricted Differential Revision
Parents
rG9c55c1cf567c: bhyve: validate e82545 checksum offset field
Branches
Unknown
Tags
Unknown