HomeFreeBSD

nvme_ctrlr_enable: Remove unnecessary 5ms delays

Description

nvme_ctrlr_enable: Remove unnecessary 5ms delays

Remove the 5ms delays after writing the administrative queue
registers. These delays are from the very earliest days of the driver
(they are in the first commit) and were most likely vestiges of the
Chatham NVMe prototype card that was used to create this driver. Many of
the workarounds necessary for it aren't necessary for standards
compliant cards. The original driver had other areas marked for Chatham,
but these were not. They are unneeded. There's three lines of supporting
evidence.

First, the NVMe standards make no mention of a delay time after these
registers are written. Second, the Linux driver doesn't have them, even
as an option. Third, all my nvme cards work w/o them.

To be safe, add a write barrier between setting up the admin queue and
enabling the controller.

Sponsored by: Netflix
Reviewed by: mav
Differential Revision: https://reviews.freebsd.org/D32247

(cherry picked from commit d5fca1dc1d7de15695b65374d6457abd29a747ee)

Details

Provenance
impAuthored on Oct 1 2021, 4:47 PM
mavCommitted on Jan 21 2022, 2:07 AM
Reviewer
mav
Differential Revision
D32247: nvme_ctrlr_enable: Remove delays
Parents
rG1397c8ebb7ef: nvme: Sanity check completion id
Branches
Unknown
Tags
Unknown