HomeFreeBSD

inpcb: Close some SO_REUSEPORT_LB races

Description

inpcb: Close some SO_REUSEPORT_LB races

For a long time, the inpcb lookup path has been lockless in the common
case: we use net_epoch to synchronize lookups. However, the routines
which update lbgroups were not careful to synchronize with unlocked
lookups. I believe that in the worst case this can result in spurious
connection aborts (I have a regression test case to exercise this), but
it's hard to be certain.

Modify in_pcblbgroup* routines to synchronize with unlocked lookup:

  • When removing inpcbs from an lbgroup, do not shrink the array. The maximum number of lbgroup entries is INPCBLBGROUP_SIZMAX (256), and it doesn't seem worth the complexity to shrink the array when a socket is removed.
  • When resizing an lbgroup, do not insert it into the hash table until it is fully initialized; otherwise lookups may observe a partially constructed lbgroup.
  • When adding an inpcb to the group, increment the counter after adding the array entry, using a release store. Otherwise it's possible for lookups to observe a null array slot.
  • When looking up an entry, use a corresponding acquire load.

Reviewed by: ae, glebius
MFC after: 1 month
Sponsored by: Klara, Inc.
Sponsored by: Stormshield
Differential Revision: https://reviews.freebsd.org/D48020

Details

Provenance
markjAuthored on Thu, Dec 12, 2:02 PM
Reviewer
ae
Differential Revision
D48020: inpcb: Close some SO_REUSEPORT_LB races
Parents
rG9ea8d692f4cb: ipfw: use only needed TCP flags for state tracking
Branches
Unknown
Tags
Unknown