HomeFreeBSD

vm_reserv: Fix list locking in vm_reserv_reclaim_contig()

Description

vm_reserv: Fix list locking in vm_reserv_reclaim_contig()

The per-domain partpop queue is locked by the combination of the
per-domain lock and individual reservation mutexes.
vm_reserv_reclaim_contig() scans the queue looking for partially
populated reservations that can be reclaimed in order to satisfy the
caller's allocation.

During the scan, we drop the per-domain lock. At this point, the rvn
pointer may be invalidated. Take care to load rvn after re-acquiring
the per-domain lock.

While here, simplify the condition used to check whether a reservation
was dequeued while the per-domain lock was dropped.

Reviewed by: alc, kib
Reported by: gallatin
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D29203

Details

Provenance
markjAuthored on Mar 11 2021, 3:34 PM
Reviewer
alc
Differential Revision
D29203: vm_reserv: Fix list locking in vm_reserv_reclaim_contig()
Parents
rG1645a4ae645f: usb: tiny formatting nit
Branches
Unknown
Tags
Unknown