HomeFreeBSD

asa: Rewrite to fix line termination issue.

Description

asa: Rewrite to fix line termination issue.

The standard is somewhat unclear, but on the balance, I believe that the
phrase “the rest of the input line” should be interpreted to mean the
rest of the input line including the terminating newline if and only if
there is one. This means the current implementation is incorrect on two
points:

  • First, it suppresses the previous line's newline in the '1' case.
  • Second, it unconditionally emits a newline at the end of the output for non-empty input, even if the input did not end with a newline.

Resolve this by rewriting the main loop. Instead of special-casing the
first line and then assuming that every line ends with a newline, we
remember how each line ends and emit that either at the beginning of
the next line or at the end of the file except in the one case ('+')
where the standard explicitly says not to.

While here, try to reduce diff to upstream a little and update their
RCS tag to reflect the fact that while we've diverged significantly
from them, we've incorporated all their changes. Remove the useless
second RCS tag.

We also update the tests to account for the change in interpretation
of the '1' case and add a test case for unterminated input.

MFC after: 1 week
Sponsored by: Klara, Inc.
Reviewed by: kevans
Differential Revision: https://reviews.freebsd.org/D43326

(cherry picked from commit c2356a440db91c106867d45c94b3d6d7bc0e50f0)

Details

Provenance
desAuthored on Jan 9 2024, 2:09 PM
Reviewer
kevans
Differential Revision
D43326: asa: Rewrite to fix line termination issue.
Parents
rG2ba859e1996a: find: Add a warning about -delete.
Branches
Unknown
Tags
Unknown