HomeFreeBSD

vm_fault: Fix vm_fault_populate()'s handling of VM_FAULT_WIRE

Description

vm_fault: Fix vm_fault_populate()'s handling of VM_FAULT_WIRE

vm_map_wire() works by calling vm_fault(VM_FAULT_WIRE) on each page in
the rage. (For largepage mappings, it calls vm_fault() once per large
page.)

A pager's populate method may return more than one page to be mapped.
If VM_FAULT_WIRE is also specified, we'd wire each page in the run, not
just the fault page. Consider an object with two pages mapped in a
vm_map_entry, and suppose vm_map_wire() is called on the entry. Then,
the first vm_fault() would allocate and wire both pages, and the second
would encounter a valid page upon lookup and wire it again in the
regular fault handler. So the second page is wired twice and will be
leaked when the object is destroyed.

Fix the problem by modify vm_fault_populate() to wire only the fault
page. Also modify the error handler for pmap_enter(psind=1) to not test
fs->wired, since it must be false.

PR: 260347
Reviewed by: alc, kib
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D33416

Details

Provenance
markjAuthored on Dec 14 2021, 8:10 PM
Reviewer
alc
Differential Revision
D33416: vm_fault: Fix vm_fault_populate()'s handling of VM_FAULT_WIRE
Parents
rG509f1a0f405d: ipsec: fix a logic error in key_do_getnewspi
Branches
Unknown
Tags
Unknown