HomeFreeBSD

stand/uboot: Explain why we test for NULL here

Description

stand/uboot: Explain why we test for NULL here

Most parsedev routines assume that idev is non-null and can always be
set. Since we break from this pattern in uboot, explain why in a
comment. devparse was invented to put a lot of common code in one place
and to simplify the archsw.arch_getdev code and any dv_parsedev code
called. However, uboot couldn't use devparse at the time because its
device naming scheme slightly different parsing. So, we still use
uboot_parsedev directly from uboot_getdev where dev could be NULL. Add a
comment to this effect.

The match functionality added for ofw likely could be used to clean up
the multiple kludges that are here for uboot's device naming differences
with the normal boot loader. This work will wait for the future.

Sponsored by: Netflix
Reviewed by: kevans
Differential Revision: https://reviews.freebsd.org/D38042

Details

Provenance
impAuthored on Jan 13 2023, 9:19 PM
Reviewer
kevans
Differential Revision
D38042: stand/uboot: Explain why we test for NULL here
Parents
rGd38d8a4c4e9a: stand/ofw: dev can't be NULL here
Branches
Unknown
Tags
Unknown