HomeFreeBSD

tarfs: Fix two input validation issues.

Description

tarfs: Fix two input validation issues.

  • Reject hard or soft links with an empty target path. Currently, a debugging kernel will hit an assertion in tarfs_lookup_path() while a non-debugging kernel will happily create a link to the mount root.
  • Use a temporary variable to store the result of the link target path, and copy it to tnp->other only once we have found it to be valid. Otherwise we error out after creating a reference to the target but before incrementing the target's reference count, which results in a use-after-free situation in the cleanup code.
  • Correctly return ENOENT from tarfs_lookup_path() if the requested path was not found and create_dirs is false. Luckily, existing callers did not rely solely on the return value.

MFC after: 3 days
PR: 277360
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.
Reviewed by: sjg
Differential Revision: https://reviews.freebsd.org/D44161

Details

Provenance
desAuthored on Mar 6 2024, 4:13 PM
Reviewer
sjg
Differential Revision
D44161: tarfs: Fix two input validation issues.
Parents
rGd0168b32bc67: vmm.4: Add verbiage about need to load module from loader.conf
Branches
Unknown
Tags
Unknown