HomeFreeBSD

nfsclient: Copy only initialized fields in nfs_getattr()

Description

nfsclient: Copy only initialized fields in nfs_getattr()

When loading attributes from the cache, the NFS client is careful to
copy only the fields that it initialized. After fetching attributes
from the server, however, it would copy the entire vattr structure
initialized from the RPC response, so uninitialized stack bytes would
end up being copied to userspace. In particular, va_birthtime (v2 and
v3) and va_gen (v3) had this problem.

Use a common subroutine to copy fields provided by the NFS client, and
ensure that we provide a dummy va_gen for the v3 case.

Reviewed by: rmacklem
Reported by: KMSAN
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D30090

(cherry picked from commit 8bde6d15d1fa9a947c2bdc5eddae36cfbb1076dc)

Details

Provenance
markjAuthored on May 4 2021, 12:53 PM
Reviewer
rmacklem
Differential Revision
D30090: nfsclient: Copy only initialized fields in nfs_getattr()
Parents
rG852b394f6f60: pf: Trivial typo fix
Branches
Unknown
Tags
Unknown