HomeFreeBSD

pam_krb5: Clarify a loop condition.

Description

pam_krb5: Clarify a loop condition.

The closing parenthesis was in the wrong location, so instead of assigning the return value to krbret and then comparing it to zero, we were assigning the result of the comparison to krbret and then comparing that to zero. This has no practical significance since the value is not used after the loop terminates.

PR: 229719
Reviewed by: cy
Differential Revision: https://reviews.freebsd.org/D41299

(cherry picked from commit acc7cf8641dcedad295ff0e569c3f3a28939ada0)

pam_krb5: Rename a variable.

Reviewed by: cy
Differential Revision: https://reviews.freebsd.org/D41300

(cherry picked from commit 9c2823bae92c09e5356623118da2777bc3ed521d)

Details

Provenance
desAuthored on Aug 4 2023, 4:08 PM
Reviewer
cy
Differential Revision
D41299: pam_krb5: Clarify a loop condition.
Parents
rG1fb1008822c6: forkpty: Avoid fd leak if fork() fails.
Branches
Unknown
Tags
Unknown