HomeFreeBSD

Improve block sizes checks during cloning

Description

Improve block sizes checks during cloning

  • Fail if source block is smaller than destination. We can only

grow blocks, not shrink them.

  • Fail if we do not have full znode range lock. In that case grow

is not even called. We should improve zfs_rangelock_cb() somehow
to know when cloning needs to grow the block size unlike write.

  • Fail of we tried to resize, but failed. There are many reasons

for it to fail that we can not predict at this level, so be ready
for them. Unlike write, that may proceed after growth failure,
block cloning can't and must return error.

This fixes assertion inside dmu_brt_clone() when it sees different
number of blocks held in destination than it got block pointers.
Builds without ZFS_DEBUG returned EXDEV, so are not affected much.

Reviewed-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15724
Closes #15735

Details

Provenance
mavAuthored on Jan 9 2024, 5:46 PM
GitHub <noreply@github.com>Committed on Jan 9 2024, 5:46 PM
Parents
rG7ecaa0758005: make zdb_decompress_block check decompression reliably
Branches
Unknown
Tags
Unknown