HomeFreeBSD

smp_targeted_tlb_shootdown has to pin the CPU on i386

Description

smp_targeted_tlb_shootdown has to pin the CPU on i386

This should fix a regression in 1820ca215461 which happened
because pmap -> shootdown contracts on amd64 and i386 diverged.
On amd64 the pmap code always pins the CPU before calling the shootdown
code and expects it to unpin on return.
On i386 the pmap code either has pins and unpins around the shootdown
calls or does not pin at all.
This change should account for that difference.

In main and stable/13 the contracts are also different, but the
shootdown code is split into the i386 and amd64 variants and each
variant is tailored towards the platform's pmap.

PR: 261338
Reported by: Dmitry K. <thedix@yandex.ru>
Debugged by: Dmitry K. <thedix@yandex.ru>
Tested by: Dmitry K. <thedix@yandex.ru>
Fixes: 1820ca215461 MFC r368649 / 3fd989da by kib: amd64 pmap: fix PCID mode invalidations
Reviewed by: kib
X-Pointyhat to: avg
Differential Revision: https://reviews.freebsd.org/D33980

(cherry picked from commit e0cc1ce7c0866d6a5c42ef09cfca9582c4a8343c)

Approved by: so
Security: FreeBSD-EN-22:08.i386

Details

Provenance
avgAuthored on Jan 25 2022, 10:34 AM
gordonCommitted on Feb 1 2022, 5:50 PM
Reviewer
kib
Differential Revision
D33980: smp_targeted_tlb_shootdown has to pin the CPU on i386
Parents
rG432bc9ea6c0c: Add UPDATING entries and bump version
Branches
Unknown
Tags
Unknown