Page MenuHomeFreeBSD

talg_cs.stanford.edu (Tal Garfinkel)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2018, 8:33 PM (121 w, 4 d)

Recent Activity

Sep 11 2018

talg_cs.stanford.edu added a comment to D14609: Split libc into libc and libsys.
Sep 11 2018, 6:25 PM
talg_cs.stanford.edu abandoned D14803: *Added SAL to system calls declarations in syscalls.master, some annotations were ported over from syscalls.master in cheribsd..

landed in different revision.

Sep 11 2018, 6:21 PM

Mar 23 2018

talg_cs.stanford.edu added a comment to D14285: Added SAL annotatations to system calls.

sorry about dribbling in the last set of fixes. that should address all the issues raised.

Mar 23 2018, 1:04 AM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • -rebased against master to pull in getrandom and added annotation.
Mar 23 2018, 1:01 AM
talg_cs.stanford.edu created D14803: *Added SAL to system calls declarations in syscalls.master, some annotations were ported over from syscalls.master in cheribsd..
Mar 23 2018, 12:58 AM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • removed line break.
Mar 23 2018, 12:46 AM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • formatting fixed a few missing annotations added.
Mar 23 2018, 12:44 AM

Mar 16 2018

talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • addresses brook's comments.
  • adds annotations for COMPAT* i.e. COMPAT10,7,...
  • adds annotations for NOSTD calls
  • reformats everything to not exceed 80 columns.
  • adds/removes some comments.
  • also fixes annotation for pwrite
Mar 16 2018, 8:08 PM
talg_cs.stanford.edu updated the summary of D14285: Added SAL annotatations to system calls.
Mar 16 2018, 7:28 PM

Mar 9 2018

talg_cs.stanford.edu updated the summary of D14285: Added SAL annotatations to system calls.
Mar 9 2018, 12:10 AM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • Added SAL annotations for COMPAT11 syscalls.
Mar 9 2018, 12:09 AM

Mar 8 2018

talg_cs.stanford.edu added a comment to D14285: Added SAL annotatations to system calls.

If everyone is happy with the documentation and new annotations I think this is ready to land.

Mar 8 2018, 1:11 AM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
-rebased against latest HEAD.
Mar 8 2018, 1:08 AM
talg_cs.stanford.edu abandoned D14616: *Added SAL annotatations to latest bsd system calls declarations in syscalls.master, annotations were ported over from syscalls.master in cheribsd..
Mar 8 2018, 1:07 AM
talg_cs.stanford.edu created D14616: *Added SAL annotatations to latest bsd system calls declarations in syscalls.master, annotations were ported over from syscalls.master in cheribsd..
Mar 8 2018, 1:06 AM

Mar 7 2018

talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • replaced tab with spaces for uniform formatting.
Mar 7 2018, 10:43 PM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • tiny wording change in documentation.
Mar 7 2018, 10:42 PM
talg_cs.stanford.edu updated the summary of D14285: Added SAL annotatations to system calls.
Mar 7 2018, 10:23 PM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • fixed incorrect annotation for cpuset_getdomain.
Mar 7 2018, 10:20 PM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • -added annotations for remaining calls of type COMPAT and STD for consistency/completeness.
Mar 7 2018, 10:10 PM
talg_cs.stanford.edu updated the summary of D14285: Added SAL annotatations to system calls.
Mar 7 2018, 7:44 PM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • Added documentation for annotations to header comment block.
Mar 7 2018, 7:43 PM
talg_cs.stanford.edu abandoned D14512: Changed audit tag name to match system call name..

got it, was confused about the reason for the mismatch between audit tag and name...

Mar 7 2018, 7:08 PM

Mar 5 2018

talg_cs.stanford.edu added a comment to D14285: Added SAL annotatations to system calls.

I think it would be good to describe at least _In_, _Inout_, _Out_, and _opt_ annotation components not just that they are SAL 2.0 annotations since SAL doesn't google very well.

Mar 5 2018, 11:28 PM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • Added a note about SAL annotations to header comments re: emaste and jhb's comments.
Mar 5 2018, 10:25 PM
talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • added annotatations for gethostname, sethostname, revoke, pathconf.
Mar 5 2018, 10:03 PM

Mar 2 2018

talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
  • added missing annotations for send and recv.
Mar 2 2018, 6:35 PM

Feb 26 2018

talg_cs.stanford.edu updated the diff for D14285: Added SAL annotatations to system calls.
-fixed kevent annotation
-removed cheri relavent comment
-fixed syscall type for call 460, picked up difference from cheribsd.
Feb 26 2018, 11:03 PM
talg_cs.stanford.edu updated the diff for D14512: Changed audit tag name to match system call name..
  • related changes
Feb 26 2018, 2:15 AM
talg_cs.stanford.edu created D14512: Changed audit tag name to match system call name..
Feb 26 2018, 2:12 AM

Feb 9 2018

talg_cs.stanford.edu created D14285: Added SAL annotatations to system calls.
Feb 9 2018, 7:36 PM