Page MenuHomeFreeBSD

richard_meric.id.au (Richard Begg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2019, 6:28 AM (54 w, 1 d)

Recent Activity

Jan 16 2019

richard_meric.id.au added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Not sure about the seg_max value (even in the current code).
Looking at the qemu implementation, I suspect it should be queue length -2, which I guess is what the patched code happens to achieve (based on the definition of VTBLK_RINGSZ), but it could be more explicit.

Jan 16 2019, 6:01 AM · bhyve

Jan 14 2019

richard_meric.id.au added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Hi Richard,
Do you mind share the tests you made??
Best,

Jan 14 2019, 6:11 AM · bhyve
richard_meric.id.au added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

This is effectively what we did in SmartOS/illumos to address the issue:
https://github.com/joyent/illumos-joyent/commit/192e1e6405f98e4b0a12f9488793c5dd000f3f7e
I would suggest including a comment where vbc_seg_max is set to note why that value is clamped as it is.

Jan 14 2019, 12:51 AM · bhyve
richard_meric.id.au updated the diff for D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Added comment where vbc_seg_max is set to note why that value is clamped as it is (as recommended by pmooney_pfmooney.com).

Jan 14 2019, 12:48 AM · bhyve

Jan 13 2019

richard_meric.id.au updated the diff for D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Fix cut-and-paste error in patch

Jan 13 2019, 7:08 AM · bhyve
richard_meric.id.au created D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.
Jan 13 2019, 6:49 AM · bhyve