In D56115#1285041, @imp wrote:

Current adopted the upstream edk ii headers. Efierr is gone. I plan on mfcing that to 15, i think as the lessor evil.

In D56115#1284679, @bms wrote:

I only see efierr.h in older trees I have around. e.g. EFI_DEVICE_ERROR seems to be only defined in sys/contrib/edk2/Include/Uefi/UefiBaseType.h in -CURRENT.

In D56115#1284430, @imp wrote:

In D56115#1284186, @iyan005_outlook.com wrote:

Ok, i corrected the single line comments, and verified the return value
of the BS call, against EFI_ERROR.

However i have a question regarding the return value in case of errors.

The UEFI spec (https://uefi.org/specs/UEFI/2.10/07_Services_Boot_Services.html#efi-boot-services-getnextmonotoniccount)
section 7.5.5 specifies only 2 possibles errors, either a device related error, or a null pointer is passed to the function (EFI_DEVICE_ERROR, EFI_INVALID_PARAMETER)

So we've seen functions grow new errors over time, or some implementations return other errors for reasons that were consistent with the standard, but maybe not one of the ones listed.

Hello, I'm still figuring out the proper way to do things in phabricator, so i was just wondering :

Ok, i corrected the single line comments, and verified the return value
of the BS call, against EFI_ERROR.

addressed inline comments.

implemented the suggestions of bms from the previous review
and improved error handling to use the correct macro

Ok, I just went over your suggestions, implemented them, and also followed proper fts testing "etiquette" by using the designated structures for the job.