yes, you are right; i have changed it
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 29 2023
Jun 29 2023
daniel_octaforge.org requested review of D40802: seq(1): print integers up to 2^mantissa as integers.
Jun 4 2023
Jun 4 2023
daniel_octaforge.org added a comment to D40415: sh(1): make smark a static variable instead of a local in main().
daniel_octaforge.org updated the diff for D40415: sh(1): make smark a static variable instead of a local in main().
Jun 3 2023
Jun 3 2023
proper patch: https://reviews.freebsd.org/D40415
Now that I am thinking about it, this may not be a compiler issue - the C standard specifies that the value of non-volatile local variables modified between the setjmp call and the longjmp is unspecified. So making these static is actually the right way to go.
This patch actually works around the problem:
and indeed, further testing reveals that the issue does not get fixed by this change (nor by moving setstackmark), only hidden; any changes to smark contents are *not* visible after the jump, which in practice means we are most likely leaking memory, or worse
@jilles I looked into this more and it seems that this is actually a miscompilation, possibly caused by the LLVM optimizer getting confused because of the long jumps.