Hmm, yes, I think the rtsx_flags field should be protected by the lock in the MMCCAM version. I will update this review soon.

For my personal information:

the split is OK

You split the rtsx_card_task() function between MMCCAM and not MMCCAM before introducing your update of the use of device lock.

Now that 13.2-RELEASE is almost done I think it would be nice to have this update committed for 14.0-RELEASE.
With the PNP, the kernel is smaller for the configuration without Realtek.

• Remove rtsx from amd64 and i386 GENERIC configuration

• Remove support for FreeBSD 11 and earlier

Add ThinkPad X13 Gen 1 into inversion models

The patch is OK.

reuse the list from main probe function for MODULE_PNP_INFO()

Comment rtsx device in GENERIC

Please commit this updated driver so that it can be MFCed for 13.1 release.

• Remove a bug no longer present

• Replace rtsx_debug and rtsx_trace by rtsx_debug_mask

• Replace FreeBSD by __FreeBSD_version

• Don't display pci_read_config() errors during rtsx_init()
• Add CTLFLAG_STATS for read and write counters

• Correct style(9): comments on #endif

Rename timeout1 by timeout_cmd & timeout2 by timeout_io

I just wonder what is blocking a commit of this update ?

Oups... previous commit message should have been:

Add two new XPT for MMC (see commit af2253f61c43 on sdhci.c)

On Mon, Jun 7 the port sysutils/rtsx-kmod has been updated to this version.
For now no problem has been encountered.

Make rtsx_debug a tunable and so available during rtsx_attach().

Small change for a better style(9) and a spelling mistake.

Just wondering what next...

• replace options INVERSION by tunable dev.rtsx.0.inversion.

Update MMCCAM implementation for 13.0-CURRENT.

• Style(9) rtsx.c (function definition).

• Modify srtlcpy so that the serial number is not truncated.

Modify rtsx_cam_* functions to return void and set better ccb status

Amend rtsx.4 and modify Makefile and rtsx.c for MMCCAM better support.

Add MMCCAM support

Update manual to add tunable for inversion.