Page MenuHomeFreeBSD
Differential D41644 Inline Comments

FAQ renew - Working Group
Back to Revision

Inline Comments

DiffStatusReviewerCommentCreated
Diff 127109emaste
are these really supposed to be unicode ellipses? … 
67 w
Diff 127109emaste
add "elected" to Core Team  
67 w
Diff 127109emaste
I'd say "many" instead of "most."  
67 w
Diff 127109emaste
I would just drop these explicit references, just mention what FreeBSD's goals are. 
67 w
Diff 127109fernape
I would remove this sentence. It does not belong to this section, but to the next one where there is already a very similar sentence. 
67 w
Diff 127109fernape
Since this does not pretend to be an exhaustive list, I would use a disjunctive: //...such as the overall direction of the project and who is allowed...// --> //...such as the overall direction of the project or who is allowed...// 
67 w
Diff 127109fernape
I'm not sure if this should be //Feel free to modify, distribute...// 
67 w
Diff 127109fernape
Although it was in the original too, shouldn't the comma be *after* //though//? //...comes with slightly more strings attached, though at least on the side of enforced access rather than the usual opposite.// --> //...comes with slightly more strings attached though, at least on the side of enforced access rather than the usual opposite.// 
67 w
Diff 127109fernape
Link to books/handbook/ports? 
67 w
Diff 127109fernape
//...between FreeBSD and NetBSD, OpenBSD, and other...// --> //...between FreeBSD, NetBSD, OpenBSD, and other...// 
67 w
Diff 127599fernape
To avoid repeating snapshot how about? //These snapshots represent a snapshot in time...// --> //These snapshots capture a moment in time...// 
67 w
Diff 127599fernape
I had the idea that there is a hard coded limit in the code... FreeBSD can support more, but then the limit needs to be changed and the kernel recompiled. 
67 w
Diff 127599carlavilla
I will ask @emaste or @jhb to see if they can help us with this question, I leave the comment unmarked. 
67 w
Diff 127599fernape
This paragraph title does not render properly, but that is most likely due to the empty body in the previous one. 
67 w
Diff 127599carlavilla
Yes, that is why, in the final version we will not have that problem :) 
67 w
Diff 127599fernape
Ummm. It doesn't render properly in the preview. 
67 w
Diff 127621fernape
I would remove this sentence. It does not belong to this section, but to the next one where there is already a very similar sentence. 
67 w
Diff 127621fernape
Since this does not pretend to be an exhaustive list, I would use a disjunctive: //...such as the overall direction of the project and who is allowed...// --> //...such as the overall direction of the project or who is allowed...// 
67 w
Diff 127621fernape
I'm not sure if this should be //Feel free to modify, distribute...// or //The license means you are free to modify...// 
67 w
Diff 127621fernape
Although it was in the original too, shouldn't the comma be **after** though? ...comes with slightly more strings attached, though at least on the side of enforced access rather than the usual opposite. --> ...comes with slightly more strings attached though, at least on the side of enforced access rather than the usual opposite. 
67 w
Diff 127621fernape
Link to books/handbook/ports? 
67 w
Diff 127621carlavilla
Personally I prefer to keep the links between documents to a minimum, but if you think it is essential to add links here, I can add the links without problems 
67 w
Diff 127621fernape
...between FreeBSD and NetBSD, OpenBSD, and other... --> ...between FreeBSD, NetBSD, OpenBSD, and other... 
67 w
Diff 127686fernape
Since we link to the Architecture Handbook, I would link to the Handbook too. 
67 w
Diff 127686fernape
Found it: ``` $ find . -name param.h -exec egrep -H '.*define.*MAXCPU.*' {} \; ./sys/amd64/include/param.h:#define MAXCPU 1024 ./sys/amd64/include/param.h:#define MAXCPU 1 ./sys/arm/include/param.h:#define MAXCPU 4 ./sys/arm/include/param.h:#define MAXCPU 1 ./sys/arm64/include/param.h:#define MAXCPU 1024 ./sys/arm64/include/param.h:#define MAXCPU 1 ./sys/i386/include/param.h:#define MAXCPU 32 ./sys/i386/include/param.h:#define MAXCPU 1 ./sys/powerpc/include/param.h:#define MAXCPU 256 ./sys/powerpc/include/param.h:#define MAXCPU 1 ./sys/riscv/include/param.h:#define MAXCPU 16 ./sys/riscv/include/param.h:#define MAXCPU 1 ``` Those are the maximum number of CPUs per architecture.  
67 w
Diff 127686carlavilla
Niceeeeeeeeeeeeeeeeeeeeeeee, thank you for that!!! 
67 w
Diff 127721fernape
While this was in the original document, I think the memory consumption of shells is of no relevance these days. 
66 w
Diff 127721carlavilla
Done :) 
66 w
Diff 127876ashish
Is it really recommended for production systems ? This[0] offers opposite advice. References: [0] https://docs.freebsd.org/en/books/handbook/cutting-edge/#stable  
65 w
Diff 127876carlavilla
Good catch :) 
65 w