Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondary
ClosedPublic
Actions

Authored by jhibbits on Dec 9 2021, 3:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 4:58 AM

	Unknown Object (File)
	Nov 22 2024, 5:26 PM

	Unknown Object (File)
	Oct 18 2024, 6:45 PM

	Unknown Object (File)
	Sep 16 2024, 6:29 PM

	Unknown Object (File)
	Sep 13 2024, 3:52 AM

	Unknown Object (File)
	Sep 2 2024, 3:02 PM

	Unknown Object (File)
	Aug 31 2024, 6:10 PM

	Unknown Object (File)
	Jul 17 2024, 3:47 PM

View All 32 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rGd2de68811a80: Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondary()

Summary

The only requirement for SV_DSO_SIG here is that the flags match between the source and target sysentvec.

The current assertion is too strict, and fails on powerpc64, causing a kernel panic. powerpc64 is the only other architecture to call exec_sysvec_init_secondary().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Dec 9 2021, 3:53 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 9 2021, 3:53 AM

jhibbits requested review of this revision.Dec 9 2021, 3:53 AM

kib accepted this revision.Dec 9 2021, 3:57 AM

This revision is now accepted and ready to land.Dec 9 2021, 3:57 AM

Closed by commit rGd2de68811a80: Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondary() (authored by jhibbits). · Explain WhyDec 9 2021, 4:55 AM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rGd2de68811a80: Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondary().

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sharedpage.c

3 lines

Diff 99759

View Options

sys/kern/kern_sharedpage.c

Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondaryClosedPublicActions