Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondary
ClosedPublic
Actions

Authored by jhibbits on Dec 9 2021, 3:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 26, 11:57 AM

	Unknown Object (File)
	Sat, Jan 25, 8:09 AM

	Unknown Object (File)
	Mon, Jan 13, 4:05 PM

	Unknown Object (File)
	Mon, Jan 13, 4:59 AM

	Unknown Object (File)
	Sun, Jan 12, 3:11 PM

	Unknown Object (File)
	Sun, Jan 12, 12:04 PM

	Unknown Object (File)
	Dec 27 2024, 1:23 AM

	Unknown Object (File)
	Dec 17 2024, 4:58 AM

View All 39 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rGd2de68811a80: Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondary()

Summary

The only requirement for SV_DSO_SIG here is that the flags match between the source and target sysentvec.

The current assertion is too strict, and fails on powerpc64, causing a kernel panic. powerpc64 is the only other architecture to call exec_sysvec_init_secondary().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jhibbits created this revision.Dec 9 2021, 3:53 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 9 2021, 3:53 AM

jhibbits requested review of this revision.Dec 9 2021, 3:53 AM

kib accepted this revision.Dec 9 2021, 3:57 AM

This revision is now accepted and ready to land.Dec 9 2021, 3:57 AM

Closed by commit rGd2de68811a80: Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondary() (authored by jhibbits). · Explain WhyDec 9 2021, 4:55 AM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rGd2de68811a80: Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondary().

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sharedpage.c

3 lines

Diff 99757

View Options

sys/kern/kern_sharedpage.c

Fix assert check for SV_DSO_SIG in exec_sysvec_init_secondaryClosedPublicActions