Page MenuHomeFreeBSD

fusefs: correctly handle an inode that changes file types
ClosedPublic

Authored by asomers on Dec 6 2021, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 24, 10:28 AM
Unknown Object (File)
Wed, Jun 24, 4:41 AM
Unknown Object (File)
Tue, Jun 23, 9:11 PM
Unknown Object (File)
Tue, Jun 23, 7:49 AM
Unknown Object (File)
Thu, Jun 18, 9:10 PM
Unknown Object (File)
May 15 2026, 9:33 PM
Unknown Object (File)
May 15 2026, 9:33 PM
Unknown Object (File)
Apr 30 2026, 4:17 AM

Details

Summary

Correctly handle the situation where a FUSE server unlinks a file, then
creates a new file of a different type but with the same inode number.
Previously fuse_vnop_lookup in this situation would return EAGAIN. But
since it didn't call vgone(), the vnode couldn't be reused right away.
Fix this by immediately calling vgone() and reallocating a new vnode.

This problem can occur in three code paths, during VOP_LOOKUP,
VOP_SETATTR, or following FUSE_GETATTR, which usually happens during
VOP_GETATTR but can occur during other vops, too. Note that the correct
response actually doesn't depend on whether the entry cache has expired.
In fact, during VOP_LOOKUP, we can't even tell. Either it has expired
already, or else the vnode got reclaimed by vnlru.

Also, correct the error code during the VOP_SETATTR path.

PR: 258022
Reported by: chogata@moosefs.pro
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43167
Build 40055: arc lint + arc unit