net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script
ClosedPublic
Actions

Authored by driesm on Nov 12 2021, 8:25 AM.

Details

Reviewers

philip
0mp

Commits

R11:128e4bb46e8d: net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script

Summary

Commit Message:

net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script

The keyword was added in 2007 following git history, c7e6df59748c. This
is a remnant of the pre-VNET days. dhcpcd is perfectly capable of
running in a VNET jail so relax keyword. This allows dhcpcd to start in
a VNET jail.

 PR:			258185
 Approved by:		tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D32959

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

driesm created this revision.Nov 12 2021, 8:25 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 12 2021, 8:25 AM

driesm requested review of this revision.Nov 12 2021, 8:25 AM

Harbormaster completed remote builds in B42750: Diff 98405.Nov 12 2021, 8:25 AM

driesm edited the summary of this revision. (Show Details)Nov 12 2021, 8:26 AM

driesm added reviewers: philip, 0mp.

Bump portrevision as the package needs to be recreated.

Harbormaster completed remote builds in B42751: Diff 98406.Nov 12 2021, 8:28 AM

This commit will be made with:

--author "Lucas Toole <lucas@ltoole.com>"

In D32959#744039, @driesm wrote:

This commit will be made with:

--author "Lucas Toole <lucas@ltoole.com>"

Don't be surprised that you'll need to add an additional flag to git push ( git push --push-option=confirm-author I think, the server-side commit hook will give you the most recent details).

This revision is now accepted and ready to land.Nov 12 2021, 10:49 PM

philip accepted this revision.Nov 13 2021, 3:30 AM

Closed by commit R11:128e4bb46e8d: net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script (authored by Lucas Toole <lucas@ltoole.com>, committed by driesm). · Explain WhyNov 13 2021, 4:07 PM

This revision was automatically updated to reflect the committed changes.

driesm added a commit: R11:128e4bb46e8d: net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script.

In D32959#744419, @0mp wrote:

In D32959#744039, @driesm wrote:

This commit will be made with:

--author "Lucas Toole <lucas@ltoole.com>"

Don't be surprised that you'll need to add an additional flag to git push ( git push --push-option=confirm-author I think, the server-side commit hook will give you the most recent details).