Page MenuHomeFreeBSD
Differential D32959

net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script
ClosedPublic
Actions

Authored by driesm on Nov 12 2021, 8:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 11:34 PM
Unknown Object (File)
Thu, Feb 20, 1:15 AM
Unknown Object (File)
Sun, Feb 9, 10:43 AM
Unknown Object (File)
Mon, Feb 3, 10:11 AM
Unknown Object (File)
Mon, Feb 3, 9:53 AM
Unknown Object (File)
Mon, Feb 3, 7:16 AM
Unknown Object (File)
Jan 21 2025, 2:12 PM
Unknown Object (File)
Dec 14 2024, 12:21 AM
View All Files
Subscribers
mat

Details

Reviewers
philip
0mp
Commits
R11:128e4bb46e8d: net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script
Summary

Commit Message:

net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script

The keyword was added in 2007 following git history, c7e6df59748c. This
is a remnant of the pre-VNET days. dhcpcd is perfectly capable of
running in a VNET jail so relax keyword. This allows dhcpcd to start in
a VNET jail.

 PR:			258185
 Approved by:		tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D32959

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 42750
Build 39638: arc lint + arc unit

Event Timeline

driesm created this revision.Nov 12 2021, 8:25 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 12 2021, 8:25 AM
driesm requested review of this revision.Nov 12 2021, 8:25 AM
Harbormaster completed remote builds in B42750: Diff 98405.Nov 12 2021, 8:25 AM
driesm edited the summary of this revision. (Show Details)Nov 12 2021, 8:26 AM
driesm added reviewers: philip, 0mp.
driesm updated this revision to Diff 98406.Nov 12 2021, 8:27 AM

Bump portrevision as the package needs to be recreated.

Harbormaster completed remote builds in B42751: Diff 98406.Nov 12 2021, 8:28 AM
driesm added a comment.Nov 12 2021, 8:29 AM

This commit will be made with:

--author "Lucas Toole <lucas@ltoole.com>"

0mp accepted this revision.Nov 12 2021, 10:49 PM
In D32959#744039, @driesm wrote:

This commit will be made with:

--author "Lucas Toole <lucas@ltoole.com>"

Don't be surprised that you'll need to add an additional flag to git push ( git push --push-option=confirm-author I think, the server-side commit hook will give you the most recent details).

This revision is now accepted and ready to land.Nov 12 2021, 10:49 PM
philip accepted this revision.Nov 13 2021, 3:30 AM
Closed by commit R11:128e4bb46e8d: net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script (authored by Lucas Toole <lucas@ltoole.com>, committed by driesm). · Explain WhyNov 13 2021, 4:07 PM
This revision was automatically updated to reflect the committed changes.
driesm added a commit: R11:128e4bb46e8d: net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script.
driesm added a comment.Nov 13 2021, 4:08 PM
In D32959#744419, @0mp wrote:
In D32959#744039, @driesm wrote:

This commit will be made with:

--author "Lucas Toole <lucas@ltoole.com>"

Don't be surprised that you'll need to add an additional flag to git push ( git push --push-option=confirm-author I think, the server-side commit hook will give you the most recent details).

Thanks for the heads up!

Revision Contents
Changeset List

PathSize
net/
dhcpcd/
files/
2 lines

Diff 98405

View Options

net/dhcpcd/files/dhcpcd.in

Loading...