Differential D32909

net/dhcpcd: Remove stale CONFLICTS_INSTALL line
ClosedPublic
Actions

Authored by driesm on Nov 9 2021, 4:12 PM.

Tags

None

Referenced Files

	F153082431: D32909.id98255.diff
	Sun, Apr 19, 12:34 AM

	F153082430: D32909.id98304.diff
	Sun, Apr 19, 12:34 AM

	F153064369: D32909.diff
	Sat, Apr 18, 10:14 PM

	Unknown Object (File)
	Fri, Apr 17, 1:46 AM

	Unknown Object (File)
	Wed, Apr 15, 10:28 AM

	Unknown Object (File)
	Tue, Apr 14, 2:22 AM

	Unknown Object (File)
	Tue, Apr 14, 2:01 AM

	Unknown Object (File)
	Sat, Apr 11, 11:48 AM

Subscribers

Details

Reviewers

philip
0mp

Commits

R11:fdf15484210d: net/dhcpcd: Remove stale CONFLICTS_INSTALL line

Summary

Commit message:

net/dhcpcd: Remove stale CONFLICTS_INSTALL line

net/dhcpcd-devel which conflicted was removed from the tree in
f043c1154abf.

 Approved by:		tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D32909

As a general question, it might be interesting to reference the commit in the commit message where net/dhcpcd-devel was removed. What is the best approach to do this? Does "Fixes:" apply here?

Commit in question:
https://cgit.freebsd.org/ports/commit/net/dhcpcd-devel?id=f043c1154abf29b66f4cadfdcf226035a937d23b

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 42677
Build 39565: arc lint + arc unit

Event Timeline

driesm created this revision.Nov 9 2021, 4:12 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 9 2021, 4:12 PM

driesm requested review of this revision.Nov 9 2021, 4:12 PM

Harbormaster completed remote builds in B42677: Diff 98255.Nov 9 2021, 4:12 PM

driesm edited the summary of this revision. (Show Details)Nov 9 2021, 4:14 PM

driesm added reviewers: philip, 0mp.

driesm edited the summary of this revision. (Show Details)

I'd just add a note in the commit message that the conflicting port was removed in such and such commit.

Please update the description with the final commit message and I'll happily approve it.

This revision now requires changes to proceed.Nov 9 2021, 9:25 PM

I don't think "Fixes" is appropriate here. The commit didn't actually break this port.

Agree with @0mp.

Suggested wording: "net/dhcpcd-devel which conflicted was removed from the tree in f043c1154abf."

driesm edited the summary of this revision. (Show Details)Nov 10 2021, 7:59 AM

philip accepted this revision.Nov 10 2021, 8:06 AM

0mp accepted this revision.Nov 10 2021, 9:54 AM

This revision is now accepted and ready to land.Nov 10 2021, 9:54 AM

Closed by commit R11:fdf15484210d: net/dhcpcd: Remove stale CONFLICTS_INSTALL line (authored by driesm). · Explain WhyNov 10 2021, 10:29 AM

This revision was automatically updated to reflect the committed changes.

driesm added a commit: R11:fdf15484210d: net/dhcpcd: Remove stale CONFLICTS_INSTALL line.

Revision Contents
Changeset List

Path

Size

net/

dhcpcd/

2 lines

Diff 98255

net/dhcpcd/Makefile

Loading...