Page MenuHomeFreeBSD
Differential D32545

devel/stlink: Fix build on 32 bit platforms
ClosedPublic
Actions

Authored by yasu on Oct 18 2021, 10:36 AM.
Tags
None
Referenced Files
F167290670: D32545.diff
Thu, Aug 20, 5:06 PM
F167210332: D32545.id97043.diff
Wed, Aug 19, 11:31 PM
Unknown Object (File)
Tue, Aug 18, 12:53 PM
Unknown Object (File)
Tue, Aug 18, 12:53 PM
Unknown Object (File)
Sun, Aug 16, 1:27 AM
Unknown Object (File)
Sun, Aug 9, 10:50 AM
Unknown Object (File)
Sun, Aug 9, 9:36 AM
Unknown Object (File)
Sun, Aug 9, 9:31 AM
View All Files
Subscribers
diizzy
mat

Details

Reviewers
meta
ygy
Commits
R11:8c44014b13dd: devel/stlink: Fix build on 32 bit platforms
R11:b6534ecd950c: devel/stlink: Fix build on 32 bit platforms
Summary
  • Switch to DISTVERSION
  • Pet portclippy
  • Reformat Makefile with portfmt

PR: 257708
Approved by: maitainer timeout (> 1 month), meta (mentor),

		ygy (mentor)
Test Plan

Build succeeds with poudriere and 13.0-RELEASE {amd64|i386} jails.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yasu created this revision.Oct 18 2021, 10:36 AM
Herald added a subscriber: mat. · View Herald TranscriptOct 18 2021, 10:36 AM
yasu requested review of this revision.Oct 18 2021, 10:36 AM
Harbormaster completed remote builds in B42221: Diff 97043.Oct 18 2021, 10:36 AM
yasu updated this revision to Diff 97044.Oct 18 2021, 10:37 AM

Add 'Differential Revision:' to commit message.

Harbormaster completed remote builds in B42222: Diff 97044.Oct 18 2021, 10:37 AM
diizzy added a subscriber: diizzy.EditedOct 18 2021, 12:06 PM

If this enforces -O2 which it seems like it does since we're removing -Werror in the same section it should also be disabled as per guidelines in Committers Handbook
https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags

yasu updated this revision to Diff 97089.Oct 19 2021, 12:54 AM

Update files/patch-cmake_modules_c__flags.cmake so optimization flags
are removed from cmake/modules/c_flags.cmake.

Harbormaster completed remote builds in B42246: Diff 97089.Oct 19 2021, 12:54 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 27 2021, 3:56 PM
Closed by commit R11:b6534ecd950c: devel/stlink: Fix build on 32 bit platforms (authored by fuz, committed by yasu). · Explain Why
This revision was automatically updated to reflect the committed changes.
yasu added a commit: R11:b6534ecd950c: devel/stlink: Fix build on 32 bit platforms.
yasu added a commit: R11:8c44014b13dd: devel/stlink: Fix build on 32 bit platforms.Oct 27 2021, 4:01 PM

Revision Contents
Changeset List

Diff 97560

View Options

devel/stlink/Makefile

Loading...
View Options

devel/stlink/files/patch-CMakeLists.txt

Loading...
View Options

devel/stlink/files/patch-cmake_modules_c__flags.cmake

Loading...
View Options

devel/stlink/files/patch-doc_dev_pkg-config_CMakeLists.txt

Loading...
View Options

devel/stlink/files/patch-doc_man_CMakeLists.txt

Loading...
View Options

devel/stlink/files/patch-src_common.c

Loading...