graphics/gpu-firmware-gpu: Rework the ports to be a metaport
AbandonedPublic
Actions

Authored by manu on Oct 14 2021, 4:06 PM.

Details

Reviewers

None

Group Reviewers

x11

Summary

This creates three new ports :

gpu-firmware-amd-kmod
gpu-firmware-intel-kmod
gpu-firmware-radeon-kmod

Each of them is a flavored ports with each GPU generation in
their own flavor. This allow a user to only install the needed
kmods for their machine.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu requested review of this revision.Oct 14 2021, 4:06 PM

manu created this revision.

jmd added a subscriber: jmd.Oct 14 2021, 10:06 PM

Subscribed as reviewer as current maintainer of graphics/gpu-firmware-kmod - which this review also changes ownership to x11@.

Does this require users in the future to need to understand both the make and generation of their respective GPU to select the correct flavor of the port? I.e., do I interpret correctly that radeon defaults to aruba, intel defaults to skylake, and amdgpu defaults to banks.

My impression from the Linux side of the world is that firmware is one package on typical distributions.

In D32497#733204, @jmd wrote:

Subscribed as reviewer as current maintainer of graphics/gpu-firmware-kmod - which this review also changes ownership to x11@.

Does this require users in the future to need to understand both the make and generation of their respective GPU to select the correct flavor of the port? I.e., do I interpret correctly that radeon defaults to aruba, intel defaults to skylake, and amdgpu defaults to banks.

No, those are just the default flavor which is needed to have.
gpu-firmware-kmod depends on all flavor so nothing is changing for the users, they just now can only install one package with the firmware they need.

My impression from the Linux side of the world is that firmware is one package on typical distributions.

In D32497#733204, @jmd wrote:

My impression from the Linux side of the world is that firmware is one package on typical distributions.

Arch Linux seems to only split the amd-ucode and have a ~700MiB package otherwise, not something that I want.
Debian split the amdgpu firmware files.
Anyway, we're not Linux, it's not because they do one thing that we should do the same.

Alexander88207_protonmail.com added a subscriber: Alexander88207_protonmail.com.Oct 15 2021, 10:16 AM

I have no objections to this, as long as the default is to install all firmware, to avoid confusion for users.

Restrict the ports on some arches.

Note that for now drm-*kmod ports have a RUN_DEPENDS on gpu-firmware-kmod so it's not possible to only install one ports currently without having pkg complaining.
To remove the dep we first need to make amdgpu not panic if the firmware aren't present and then we could remove this RUN_DEPENDS.

Commited a while ago.