Page MenuHomeFreeBSD
Differential D32274

devel/ghub: Update to 3.5.4
ClosedPublic
Actions

Authored by yasu on Oct 2 2021, 7:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 21, 7:16 AM
Unknown Object (File)
Mon, Jul 20, 2:06 AM
Unknown Object (File)
Thu, Jul 16, 1:32 AM
Unknown Object (File)
Wed, Jul 15, 9:34 AM
Unknown Object (File)
Jun 26 2026, 10:10 PM
Unknown Object (File)
Jun 24 2026, 9:25 PM
Unknown Object (File)
Jun 24 2026, 8:02 AM
Unknown Object (File)
Jun 24 2026, 6:51 AM
View All Files
Subscribers
mat

Details

Reviewers
meta
ygy
Commits
R11:193f2611563f: devel/ghub: Update to 3.5.4
Summary

Don't install ghub-pkg.el as it isn't necessary.

Changes: https://github.com/magit/ghub/commits/v3.5.4
Approved by: meta (mentor), ygy (mentor)

Test Plan

Build succeeds with 13.0-RELEASE amd64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 41921
Build 38809: arc lint + arc unit

Event Timeline

yasu created this revision.Oct 2 2021, 7:09 AM
Herald added a subscriber: mat. · View Herald TranscriptOct 2 2021, 7:09 AM
yasu requested review of this revision.Oct 2 2021, 7:09 AM
Harbormaster completed remote builds in B41921: Diff 96133.Oct 2 2021, 7:09 AM
yasu updated this revision to Diff 96134.Oct 2 2021, 7:11 AM

Add 'Differential Revision:' to commit message.

Harbormaster completed remote builds in B41922: Diff 96134.Oct 2 2021, 7:11 AM
ygy added inline comments.Oct 2 2021, 7:27 AM
devel/ghub/Makefile
29

Can you share more info about why we switched from the original method?

yasu added inline comments.Oct 2 2021, 7:39 AM
devel/ghub/Makefile
29

*.el* also matches forge-pkg.el. But it is only used to create package for ELPA and unnecessary for FreeBSD port/package. So I changed way to install so forge-pkg.el isn't installed.

yasu mentioned this in D32503: devel/forge: Update to 0.3.0.Oct 15 2021, 2:04 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 27 2021, 4:17 PM
Closed by commit R11:193f2611563f: devel/ghub: Update to 3.5.4 (authored by yasu). · Explain Why
This revision was automatically updated to reflect the committed changes.
yasu added a commit: R11:193f2611563f: devel/ghub: Update to 3.5.4.

Revision Contents
Changeset List

PathSize
devel/
ghub/
11 lines
6 lines
1 line

Diff 96133

View Options

devel/ghub/Makefile

Loading...
View Options

devel/ghub/distinfo

Loading...
View Options

devel/ghub/pkg-plist

Loading...