Paths

Table of Contentst

Differential D32162

libpmc: add some AMD pmu counter aliases
ClosedPublic
Actions

Authored by mhorne on Sep 27 2021, 7:48 PM.

Tags

None

Referenced Files

	F170765866: D32162.id95856.diff
	Sun, Sep 6, 12:29 PM

	F170699480: D32162.id95793.diff
	Sun, Sep 6, 2:24 AM

	Unknown Object (File)
	Sat, Sep 5, 3:54 PM

	Unknown Object (File)
	Sat, Sep 5, 11:55 AM

	Unknown Object (File)
	Sat, Sep 5, 11:36 AM

	Unknown Object (File)
	Fri, Sep 4, 11:58 PM

	Unknown Object (File)
	Fri, Sep 4, 11:31 AM

	Unknown Object (File)
	Thu, Sep 3, 6:49 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG3c01f7415067: libpmc: add some AMD pmu counter aliases
rGa20c10893eb1: libpmc: add some AMD pmu counter aliases

Summary

Make it mostly compatible with what's defined for Intel. Except where
noted, these are defined for all of amdzen(1|2|3).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Sep 27 2021, 7:48 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 27 2021, 7:48 PM

mhorne requested review of this revision.Sep 27 2021, 7:48 PM

Harbormaster completed remote builds in B41786: Diff 95793.Sep 27 2021, 7:48 PM

emaste added inline comments.Sep 27 2021, 7:57 PM

lib/libpmc/libpmc_pmu_util.c
97	where does this one come from?

mhorne added inline comments.Sep 28 2021, 1:37 PM

lib/libpmc/libpmc_pmu_util.c
97	It is meant to invoke the `pmc.tsc(3)` class, which has exactly one event that reads the TSC. I copied it from the Intel aliases above, but looking at it now, this doesn't actually work... I will move this alias out of this file to a more appropriate place.

Drop non-functional 'cycles' alias in favor of D32197.

Harbormaster completed remote builds in B41812: Diff 95856.Sep 28 2021, 2:05 PM

emaste accepted this revision.Sep 28 2021, 3:07 PM

This revision is now accepted and ready to land.Sep 28 2021, 3:07 PM

Closed by commit rGa20c10893eb1: libpmc: add some AMD pmu counter aliases (authored by mhorne). · Explain WhySep 30 2021, 2:17 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGa20c10893eb1: libpmc: add some AMD pmu counter aliases.

mhorne added a commit: rG3c01f7415067: libpmc: add some AMD pmu counter aliases.Oct 15 2021, 3:27 PM

Revision Contents
Changeset List

Path

Size

lib/

libpmc/

libpmc_pmu_util.c

13 lines

Diff 96014

lib/libpmc/libpmc_pmu_util.c

Loading...